[mlir][affine] NFC Rename SimplifyAffineMinMax -> SimplifyAffineMinMa… #145905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xPass This is more consistent re. auto-generated names like `createSimplifyAffineMinMaxPass`.
Member
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-affine Author: Nicolas Vasilache (nicolasvasilache) Changes…xPass This is more consistent re. auto-generated names like Full diff: https://github.com/llvm/llvm-project/pull/145905.diff 2 Files Affected:
diff --git a/mlir/include/mlir/Dialect/Affine/Passes.td b/mlir/include/mlir/Dialect/Affine/Passes.td
index bc7ffe23e7f52..6ad45b828f657 100644
--- a/mlir/include/mlir/Dialect/Affine/Passes.td
+++ b/mlir/include/mlir/Dialect/Affine/Passes.td
@@ -414,7 +414,7 @@ def SimplifyAffineStructures : Pass<"affine-simplify-structures", "func::FuncOp"
let constructor = "mlir::affine::createSimplifyAffineStructuresPass()";
}
-def SimplifyAffineMinMax : InterfacePass<"affine-simplify-min-max", "FunctionOpInterface"> {
+def SimplifyAffineMinMaxPass : InterfacePass<"affine-simplify-min-max", "FunctionOpInterface"> {
let summary = "Simplify affine min/max/apply";
let description = [{
Apply the SimplifyAffineMaxOp, SimplifyAffineMinOp and SimplifyAffineApplyOp
diff --git a/mlir/lib/Dialect/Affine/Transforms/SimplifyAffineMinMax.cpp b/mlir/lib/Dialect/Affine/Transforms/SimplifyAffineMinMax.cpp
index 21443a55a35ad..2cb78d2b94c63 100644
--- a/mlir/lib/Dialect/Affine/Transforms/SimplifyAffineMinMax.cpp
+++ b/mlir/lib/Dialect/Affine/Transforms/SimplifyAffineMinMax.cpp
@@ -240,14 +240,15 @@ struct SimplifyAffineApplyOp : public OpRewritePattern<AffineApplyOp> {
namespace mlir {
namespace affine {
-#define GEN_PASS_DEF_SIMPLIFYAFFINEMINMAX
+#define GEN_PASS_DEF_SIMPLIFYAFFINEMINMAXPASS
#include "mlir/Dialect/Affine/Passes.h.inc"
} // namespace affine
} // namespace mlir
/// Creates a simplification pass for affine min/max/apply.
struct SimplifyAffineMinMaxPass
- : public affine::impl::SimplifyAffineMinMaxBase<SimplifyAffineMinMaxPass> {
+ : public affine::impl::SimplifyAffineMinMaxPassBase<
+ SimplifyAffineMinMaxPass> {
void runOnOperation() override;
};
|
anthonyhatran
pushed a commit
to anthonyhatran/llvm-project
that referenced
this pull request
Jun 26, 2025
llvm#145905) …xPass This is more consistent re. auto-generated names like `createSimplifyAffineMinMaxPass`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…xPass
This is more consistent re. auto-generated names like
createSimplifyAffineMinMaxPass.